[libcxx-commits] [PATCH] D102912: [libunwind] AARCH64 use inline assembly for pointer authentication

[Daniel Kiss via Phabricator via libcxx-commits]

danielkiss added a comment.

LGTM just please run once more  `git clang-format HEAD^1` on the patch.



================
Comment at: libunwind/src/DwarfInstructions.hpp:225-246
         if (cieInfo.addressesSignedWithBKey)
-          asm("hint 0xe" : "+r"(x17) : "r"(x16)); // autib1716
+        {
+            asm volatile(
+                "mov x17, %x0;"
+                "mov x16, %x1;"
+                "hint 0xe;" // autib1716
+                "mov %0, x17"
----------------
the code style is that `{` in the same line with the `if` statement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102912/new/

https://reviews.llvm.org/D102912