[libcxx-commits] [PATCH] D102006: [libcxx][ranges] Add range.subrange.

[Tim Song via Phabricator via libcxx-commits]

tcanens added inline comments.


================
Comment at: libcxx/include/__ranges/subrange.h:143
+      requires (_Kind == subrange_kind::sized)
+      : subrange(ranges::begin(__range), ranges::end(__range), __n) { }
+
----------------
cjdb wrote:
> Standard uses braces for this one.
> Standard uses braces for this one.

For ranges wording, wherever braces have behavior different from parens, the use of braces is almost certainly a defect. P2367R0 is expected to fix all such occurrences. https://github.com/cplusplus/draft/issues/4593 deals with the rest.


================
Comment at: libcxx/include/__ranges/subrange.h:146
+    template<class _Pair>
+      requires (!same_as<subrange, _Pair>) &&
+               __pair_like_convertible_from<_Pair, const _Iter&, const _Sent&>
----------------
cjdb wrote:
> Should be `__not_same_as`.
Who came up with the idea to have a exposition-only concept named //`not-same-as`// that's not `not same_as`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102006/new/

https://reviews.llvm.org/D102006