[libcxx-commits] [PATCH] D102705: Adds availability macros for std::format.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/include/__availability:145
+    // contains ABI breaking changes.
+#   define _LIBCPP_AVAILABILITY_FORMAT
+
----------------
ldionne wrote:
> Are there any feature test macros associated to this feature? If so, we'll need to disable the feature test macros when we disable the format feature (otherwise, the feature test macro will pretend that `std::format` is available, but one will get an availability error due to the attribute when trying to use it).
Yes it's depends on `__cpp_lib_format`, which is currently marked as not implemented. I'll update the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102705/new/

https://reviews.llvm.org/D102705