[libcxx-commits] [PATCH] D102844: XFAIL align.pass.pass.cpp on aix regarding atomic alignment

Hubert Tong via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 20 08:38:08 PDT 2021


hubert.reinterpretcast added inline comments.


================
Comment at: libcxx/test/libcxx/atomics/atomics.align/align.pass.pass.cpp:18
+// while the type is implied to be lock-free.
+// XFAIL: aix
+
----------------
Just trying to understand... this is a "known bug" (properly tracked) that is now being marked XFAIL to make it easier to spot other problems in regular regression testing? Might it be better to apply `#ifndef _AIX` to a subset of the calls?


================
Comment at: libcxx/test/libcxx/atomics/atomics.align/align.pass.pass.cpp:35
   atomic_test() {
     if (this->is_lock_free()) {
       using AtomicImpl = decltype(this->__a_);
----------------
So, this is returning the wrong value?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102844/new/

https://reviews.llvm.org/D102844



More information about the libcxx-commits mailing list