[libcxx-commits] [PATCH] D102763: [LLParser] Remove outdated deplibs

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

While I can appreciate the removal of deprecated functionality, I think that some sort of mention of this on llvm-dev at least 2 weeks prior to the removal is warranted.  It impacts any downstream projects which may still be relying on a feature.



================
Comment at: libcxxabi/test/test_demangle.pass.cpp:12418
     {"_ZN4llvm8LLParser21ParseTargetDefinitionEv", "llvm::LLParser::ParseTargetDefinition()"},
-    {"_ZN4llvm8LLParser12ParseDepLibsEv", "llvm::LLParser::ParseDepLibs()"},
     {"_ZN4llvm8LLParser16ParseUnnamedTypeEv", "llvm::LLParser::ParseUnnamedType()"},
----------------
This should not be removed, its a name undecoration test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102763/new/

https://reviews.llvm.org/D102763