[libcxx-commits] [PATCH] D102564: [libcxx][iterator] adds `std::ranges::prev`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

SGTM, but I would like to know what our way forward will be with `[[nodiscard]]` before approving.



================
Comment at: libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.prev/prev.pass.cpp:13
+
+// ranges::next
+
----------------
`next` -> `prev`


================
Comment at: libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.prev/prev.verify.cpp:13
+
+// ranges::next
+
----------------
`next` -> `prev`


================
Comment at: libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.prev/prev.verify.cpp:43
+  prev(x, x); // expected-error {{use of undeclared identifier 'prev'}}
+  // expected-error@*:*{{no matching function for call to 'prev'}}
+  prev(x, 0, x); // expected-error {{use of undeclared identifier 'prev'}}
----------------
@zoecarver wasn't `expected-error@*:*` an issue with older versions of Clang?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102564/new/

https://reviews.llvm.org/D102564