[libcxx-commits] [PATCH] D102657: [libcxx][ranges] Update `{front_, back_, }insert_iterator` for C++20.
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon May 17 17:09:59 PDT 2021
zoecarver added inline comments.
================
Comment at: libcxx/include/iterator:770-776
+#if _LIBCPP_STD_VER <= 17
: public iterator<output_iterator_tag,
void,
void,
void,
void>
+#endif // _LIBCPP_STD_VER <= 17
----------------
cjdb wrote:
> Quuxplusone wrote:
> > https://quuxplusone.github.io/blog/2021/05/07/std-iterator-as-a-base-class/
> It's an ABI break that I'm okay with (since I'm okay with //all// ABI breaks), but we should probably discuss this on the mailing list.
Ah yes I forgot about that discussion. Would it be better to just add a dummy base class that we inherit from in ABI-stable mode after C++17?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102657/new/
https://reviews.llvm.org/D102657
More information about the libcxx-commits
mailing list