[libcxx-commits] [PATCH] D102639: [libcxx][ranges] Add `indirectly_­movable`.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/iterators/iterator.requirements/alg.req/ind.move.compile.pass.cpp:21
+struct IndirectlyMovableWithInt {
+  int& operator*() const;
+};
----------------
I think we need some tests using a type with
```
const int& operator*() const;
```
or at least some tests using `const int*`. For example, `std::indirectly_movable<const int*, int*>` should be `false` (but `std::indirectly_movable<int*, const int*>` should be true). And `std::indirectly_movable<MoveOnly*, const MoveOnly*>` should also be false because `MoveOnly` is move-only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102639/new/

https://reviews.llvm.org/D102639