[libcxx-commits] [PATCH] D102357: [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into "UNSUPPORTED"

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius accepted this revision as: curdeius.
curdeius added inline comments.


================
Comment at: libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp:16
+// other platforms.
+// XFAIL: windows
 
----------------
mstorsjo wrote:
> curdeius wrote:
> > Your patch description said that it was going to be converted into UNSUPPORTED, right?
> Oh, right. What do you think, which marking would be better here?
No strong feelings here. I'd probably go for unsupported. Your comment clearly explains why it is so IMO. Also, unless you think it will change in a foreseeable future, it makes no sense to me to XFAIL.
But, yeah, I leave it to you (and other reviewers).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102357/new/

https://reviews.llvm.org/D102357