[libcxx-commits] [PATCH] D102360: [libcxx] [test] Change the generic_string_alloc test to do a conversion that also does something on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 13 12:09:46 PDT 2021


mstorsjo added a comment.

In D102360#2757455 <https://reviews.llvm.org/D102360#2757455>, @curdeius wrote:

> LGTM. What do you think, would there be any value in testing different char types?

Hmm, I guess it would be good to test all cases, just for completeness - amended the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102360/new/

https://reviews.llvm.org/D102360



More information about the libcxx-commits mailing list