[libcxx-commits] [PATCH] D102414: [libc++] Improve make_string test support.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 13 10:43:08 PDT 2021


Mordante added a comment.

Thanks for the reviews. I'll update the comment before landing.
I did quite a bit more on `std::format` than what's up for review. I haven't had the need for `MAKE_STRING_VIEW` so I don't foresee I'll ever need it :-)
I think you've a good point about the implicit conversion. I'll add it to my todo list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102414/new/

https://reviews.llvm.org/D102414



More information about the libcxx-commits mailing list