[libcxx-commits] [PATCH] D102414: [libc++] Improve make_string test support.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

Sure; although here are some non-blockers:

- the repeated comment is maybe overkill
- the existing code's use of implicit conversion operators (instead of say an `.as_chars<CharT>()` getter) is just horrible and I'd love to see a PR to fix it throughout the test suite
- I wonder if you're going to need `MAKE_STRING_VIEW` next


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102414/new/

https://reviews.llvm.org/D102414