[libcxx-commits] [PATCH] D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 12 15:09:04 PDT 2021


MaskRay added inline comments.


================
Comment at: libcxxabi/src/cxa_personality.cpp:971
     set_registers(unwind_exception, context, results);
+    // Cache base for calculating the address of ttype in __cxa_call_unexpected.
+    if (results.ttypeIndex < 0) {
----------------
Normal Itanium doesn't need/shouldn't have this code. `_UA_CLEANUP_PHASE` doesn't need caching.

Can you re-confirm AIX needs this? (I suspect this is not the right place to add the code.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101298/new/

https://reviews.llvm.org/D101298



More information about the libcxx-commits mailing list