[libcxx-commits] [PATCH] D102360: [libcxx] [test] Change the generic_string_alloc test to do a conversion that also does something on windows

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 12 14:29:32 PDT 2021


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Seems reasonable to me. (The existing code's `MultiStringType` is insane — took me a while to figure out why casting it to `(const char*)` on line 47 wasn't a bug — but that's not your problem.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102360/new/

https://reviews.llvm.org/D102360



More information about the libcxx-commits mailing list