[libcxx-commits] [PATCH] D102357: [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into "UNSUPPORTED"

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

This particular test relies on internal details from the libc++
filesystem implementation header, and those details are structured
differently in the implementation for windows.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102357

Files:
  libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp


Index: libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp
===================================================================
--- libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp
+++ libcxx/test/libcxx/input.output/filesystems/class.directory_entry/directory_entry.mods/last_write_time.pass.cpp
@@ -9,7 +9,11 @@
 // UNSUPPORTED: c++03
 // ADDITIONAL_COMPILE_FLAGS: -I %S/../../../../../../src/filesystem
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// This test relies on calling functions from the libcxx internal header
+// filesystem_common.h; the windows implementation uses different
+// internals and doesn't provide the same set_file_times function as for
+// other platforms.
+// XFAIL: windows
 
 // <filesystem>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102357.344917.patch
Type: text/x-patch
Size: 838 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210512/6b9e8514/attachment.bin>