[libcxx-commits] [PATCH] D102332: [libc++][nfc] remove duplicated __to_unsigned.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 12 10:22:50 PDT 2021


Mordante updated this revision to Diff 344863.
Mordante marked 2 inline comments as done.
Mordante edited the summary of this revision.
Mordante added a comment.

Addresses the review comments:

- Use the `_like` suffix since that's used in the Standard for ranges.
- Adds an extra ADL protectsion.

The builds failed since `<type_traits>` is available in C++98.
Added guards against C++98 for the new function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102332/new/

https://reviews.llvm.org/D102332

Files:
  libcxx/include/__ranges/size.h
  libcxx/include/charconv
  libcxx/include/type_traits

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102332.344863.patch
Type: text/x-patch
Size: 3707 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210512/329158c1/attachment.bin>


More information about the libcxx-commits mailing list