[libcxx-commits] [PATCH] D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 11 22:17:18 PDT 2021

cjdb added inline comments.

Comment at: libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp:22
   void(v op 0L);                                                               \
   void(0L op v);                                                               \
   void(v op nullptr);                                                          \
Mordante wrote:
> I think I wasn't clear what I meant for the `TEST_PASS`. After your change the `0L` is valid. This is the reason the number of errors reduced from 18 to 12. So after removing the two lines above the test still passes. This was the part I wanted to have in `TEST_PASS`.
> Is allowing `0L` really intended? Looking at D85051 it seems @rsmith's intention to prohibit `0L`.
> If it's intended please adjust the unit test, the patch description, and the unit tests to split the `TEST_FAIL` unit test in a fail and pass part..
Fixed, although I'm not too happy with the solution. Feels kinda hacky?

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list