[libcxx-commits] [PATCH] D98750: Apply [[standalone_debug]] to some types in the STL.

[Amy Huang via Phabricator via libcxx-commits]

akhuang added a comment.

Hm, ok, I'll wait a few days to see if @ldionne has any thoughts on this, and if not, then I think I'll just commit it.

To summarize the reasoning for going with using this attribute rather than fixing libc++: based on comments from the other patch, it seems like changing libc++ could cause more issues. Also, I couldn't find a way to apply the fix to `value_type` and `hash_value_type`, and if we have to use the attribute for those types then we might as well use it on all of them. This patch addresses the issues we have with debug info; while fixing any potential undefined behavior would be nice, it looks like it's not as straightforward to fix as we'd like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98750/new/

https://reviews.llvm.org/D98750