[libcxx-commits] [PATCH] D80895: [libcxx] adds consistent comparison for `basic_string`

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.nonmembers/string_opcmp/string_pointer.pass.cpp:14
+// template<class charT, class traits, class Allocator>
+//   auto operator<=>(const basic_string<charT,traits,Allocator>& lhs, const charT* rhs);
+
----------------
Mordante wrote:
> Please use `bool`.
No, `operator<=>` isn't `bool` though! It's one of the ordering types, and apparently depends on `_Traits` (so even changing `auto` to `std::strong_ordering` wouldn't be right). I think `auto` is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80895/new/

https://reviews.llvm.org/D80895