[libcxx-commits] [PATCH] D101728: [libcxx] [test] Fix filesystem permission tests for windows

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM, one small question.



================
Comment at: libcxx/test/support/filesystem_test_helper.h:614
+      fs::perms::owner_write | fs::perms::group_write | fs::perms::others_write;
+  if ((P & Write) != fs::perms::none)
+    P |= Write;
----------------
Is it specified which of the 3 write flags Windows sets when a file isn't read-only? Or should it set all 3 of them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101728/new/

https://reviews.llvm.org/D101728