[libcxx-commits] [PATCH] D101708: [libcxx] modifies `_CmpUnspecifiedParam` ignore types outside its domain

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 11 09:54:32 PDT 2021


Mordante added inline comments.


================
Comment at: libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp:36
+  TEST_OP(v, >=);  // expected-error 12 {{}}
+  TEST_OP(v, <=>); // expected-error 12 {{}}
 
----------------
Can you split the test macro in 2 marcos, a PASS and a FAIL? Then it's clear which of the tests are expected to a be valid and which should fail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101708/new/

https://reviews.llvm.org/D101708



More information about the libcxx-commits mailing list