[libcxx-commits] [PATCH] D101959: [libc++/abi/unwind][AIX] Add scripts and cache file for building libc++/libc++abi/libunwind

[David Tenty via Phabricator via libcxx-commits]

daltenty marked an inline comment as done.
daltenty added inline comments.


================
Comment at: libcxx/utils/ci/aix-install-libcxx.sh:107
+  )
+  env OBJECT_MODE="${bitmode}" cmake --build "${build_dir}/${bitmode}" --target install-cxx install-cxxabi install-unwind
+done
----------------
jasonliu wrote:
> jasonliu wrote:
> > If a build did not complete successfully, for the ease of find out where it fails, do we want to have an early exit whenever there is an error on setting up cmake and during building?
> For developers who invokes this script: do we want to detect if we already have a config build so that we don't need to run the cmake config every time? And provide a --clobber option if people wants to reconfig an existing config?
> If a build did not complete successfully, for the ease of find out where it fails, do we want to have an early exit whenever there is an error on setting up cmake and during building?

The `set -e` should hopefully take care of that for us.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101959/new/

https://reviews.llvm.org/D101959