[libcxx-commits] [PATCH] D102192: [libcxx][test] Make string.modifiers/clear_and_shrink_db1.pass.cpp a regular mode test
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon May 10 15:02:40 PDT 2021
Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.
If buildkite is happy with this, I'm happy. (I'm mildly confused why this test wanted to redefine `_LIBCPP_ASSERT` in the first place.)
================
Comment at: libcxx/test/libcxx/strings/basic.string/string.modifiers/clear_and_shrink.pass.cpp:37
}
}
----------------
Please add `return 0;` at the end of `main` here, for consistency with 2df59c50688c122bbcae7467d3eaf862c3ea3088 . (I don't know why it was missed in that commit, and I don't think it matters.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102192/new/
https://reviews.llvm.org/D102192
More information about the libcxx-commits
mailing list