[libcxx-commits] [PATCH] D99091: [locale][num_get] Improve Stage 2 of string to float conversion

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D99091#2704411 <https://reviews.llvm.org/D99091#2704411>, @tmatheson wrote:

> Also, can anyone suggest what I should do about the ABI issues? The function I've changed (`__num_get<_CharT>::__stage2_float_loop`) doesn't seem like it should be part of the public ABI. After updating the expected names there are still CI failures on MacOS. Should the changes be wrapped with the macros described here? https://libcxx.llvm.org/docs/DesignDocs/ABIVersioning.html

Yes the additional argument changes the ABI and should be an opt-in for the user. This can be done by adding a new define in `include/__config` in the block `#if defined(_LIBCPP_ABI_UNSTABLE) || _LIBCPP_ABI_VERSION >= 2`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99091/new/

https://reviews.llvm.org/D99091