[libcxx-commits] [PATCH] D101731: [libcxx] [test] Fix fs.op.last_write_time for Windows

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In general looks good. It would be great if we can get this working without the `compat` namespace. This would make maintenance slightly easier. Not a blocker since the CI will fail when making a mistake.



================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:40
+#endif
 #include <sys/stat.h>
 
----------------
Is the stat header required on Windows? If not would it be possible to include this header conditional and remove the `compat` namespace?


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:92
+}
+} // namespace compat
+#else
----------------
Please move this line outside the `#if` section


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:99
+using ::stat;
+} // namespace compat
+#endif
----------------
Please remove this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101731/new/

https://reviews.llvm.org/D101731