[libcxx-commits] [PATCH] D102106: [libc++] Remove workaround for PR28391 (ODR violations with ASAN)

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 8 08:16:27 PDT 2021

ldionne created this revision.
Herald added a subscriber: arichardson.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This is not an issue anymore since we don't build the libc++ dylib with
C++14 anymore (see https://llvm.org/PR28391) for details.

  rG LLVM Github Monorepo



Index: libcxx/utils/libcxx/test/config.py
--- libcxx/utils/libcxx/test/config.py
+++ libcxx/utils/libcxx/test/config.py
@@ -490,9 +490,6 @@
                 self.cxx.flags += ['-fsanitize=address']
                 if llvm_symbolizer is not None:
                     self.exec_env['ASAN_SYMBOLIZER_PATH'] = llvm_symbolizer
-                # FIXME: Turn ODR violation back on after PR28391 is resolved
-                # https://llvm.org/PR28391
-                self.exec_env['ASAN_OPTIONS'] = 'detect_odr_violation=0'
                 self.cxx.compile_flags += ['-O1']

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102106.343846.patch
Type: text/x-patch
Size: 776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210508/c947e452/attachment.bin>

More information about the libcxx-commits mailing list