[libcxx-commits] [PATCH] D101193: [libcxx][ranges] Add ranges::empty CPO.

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb commandeered this revision.
cjdb edited reviewers, added: zoecarver; removed: cjdb.
cjdb added a comment.

Commandeering with @zoecarver's permission.



================
Comment at: libcxx/test/std/ranges/range.access/range.prim/empty.pass.cpp:96
+struct sentinel {
+  constexpr bool operator==(std::input_or_output_iterator auto) const { return true; }
+};
----------------
Quuxplusone wrote:
> I'm still confused about why `sentinel` needs to be comparable to every-iterator-type-ever.
> I would rather see it scoped down to whatever specific type you're planning to compare it to (via nested member types, as shown in another of these reviews).
The effort-to-reward ratio for this doesn't really pay off. What do we gain from doing this? What do we lose by keeping it as-is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101193/new/

https://reviews.llvm.org/D101193