[libcxx-commits] [PATCH] D101922: [libcxx][iterator] adds `std::ranges::advance`

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 7 10:47:39 PDT 2021


zoecarver added inline comments.


================
Comment at: libcxx/test/support/test_iterators.h:783
+    ++distance_traversed_;
+    ++displacement_;
+    return *this;
----------------
Maybe we should have a `operations_count` too. I feel like these should be `+= n` but that's not very helpful for testing complexity. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101922/new/

https://reviews.llvm.org/D101922



More information about the libcxx-commits mailing list