[libcxx-commits] [PATCH] D102048: [libc++] Run `substitutes-in-compile-flags.sh.cpp` test on Windows.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Generally LGTM with a few comments. Ship it once reviewer feedback has been applied.



================
Comment at: libcxx/test/libcxx/selftest/additional_compile_flags/substitutes-in-compile-flags.sh.cpp:17
 // ADDITIONAL_COMPILE_FLAGS: -isystem %t.2 , -isysroot %t.3
-// RUN: echo "%{compile_flags}" | grep -e '-I %t.1 -isystem %t.2 -isysroot %t.3'
+// RUN: echo "-I %t.1 -isystem %t.2 -isysroot %t.3" | sed "s/\\\/\\\\\\\/g" > %t.grep
+// RUN: echo "%{compile_flags}" | grep -e -f %t.grep
----------------
Can you name the file something like `%t.escaped.grep` instead? It makes it more obvious that the only purpose is to escape paths.


================
Comment at: libcxx/test/libcxx/selftest/additional_compile_flags/substitutes-in-compile-flags.sh.cpp:19
+// RUN: echo "%{compile_flags}" | grep -e -f %t.grep
+// RUN: rm %t.grep
----------------
This isn't needed. We generally don't clean up the temporary files in the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102048/new/

https://reviews.llvm.org/D102048