[libcxx-commits] [PATCH] D101922: [libcxx][iterator] adds `std::ranges::advance`

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb updated this revision to Diff 343579.
cjdb marked 3 inline comments as done.
cjdb added a comment.

applies feedback from @Mordante:

- replaces leftover instances of "functionish" with "function_like"
- changes `-__n` to explicit two's complement

applies self-feedback (not listed):

- adds `output_iterator` tests
- replaces conversion to unsigned int with `__to_unsigned_like`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101922/new/

https://reviews.llvm.org/D101922

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__function_like.h
  libcxx/include/__iterator/primitives.h
  libcxx/include/iterator
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.advance/advance.pass.cpp
  libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.advance/advance.verify.cpp
  libcxx/test/support/test_iterators.h
  libcxx/test/support/test_standard_function.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101922.343579.patch
Type: text/x-patch
Size: 34053 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210507/b419ee90/attachment-0001.bin>