[libcxx-commits] [PATCH] D101959: [libc++/abi/unwind][AIX] Add scripts and cache file for building libc++/libc++abi/libunwind

[Lei Huang via Phabricator via libcxx-commits]

lei added inline comments.


================
Comment at: libcxx/utils/ci/aix-install-libcxx.sh:49
+            ;;
+        --build-type)
+            BUILD_TYPE="${2}"
----------------
Missing doc of this option in `usage()`


================
Comment at: libcxx/utils/ci/aix-install-libcxx.sh:94-95
+
+for bitmode in 32 64
+do
+  step "Building libc++.a, libc++abi.a and libunwind.a for ${bitmode}-bit"
----------------



================
Comment at: libcxx/utils/ci/aix-install-libcxx.sh:112-113
+step "Merging the resulting 32-bit and 64-bit libc++.a, libc++abi.a and libunwind.a into single libraries"
+if [[ ! -d ${install_dir}/lib ]]
+then
+	mkdir -p ${install_dir}/lib;
----------------



================
Comment at: libcxx/utils/ci/aix-install-libcxx.sh:114
+then
+	mkdir -p ${install_dir}/lib;
+fi
----------------



================
Comment at: libcxx/utils/ci/aix-install-libcxx.sh:117-124
+cd ${install_dir}/lib
+cp ${build_dir}/32/lib/libc++.a .
+cp ${build_dir}/32/lib/libc++abi.a .
+cp ${build_dir}/32/lib/libunwind.a .
+
+ar -X64 -x ${build_dir}/64/lib/libc++.a
+ar -X64 -x ${build_dir}/64/lib/libc++abi.a
----------------
All these should be quoted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101959/new/

https://reviews.llvm.org/D101959