[libcxx-commits] [PATCH] D101959: [libc++/abi/unwind][AIX] Add scripts and cache file for building libc++/libc++abi/libunwind

[Jason Liu via Phabricator via libcxx-commits]

jasonliu added a comment.

It would help if we could put the sample invocation in the summary.



================
Comment at: libcxx/utils/ci/aix-install-libcxx.sh:104-105
+        -DCMAKE_INSTALL_PREFIX="${build_dir}/${bitmode}-install" \
+        -DLIBCXX_LINK_TESTS_WITH_SHARED_LIBCXXABI=ON \
+        -DLIBCXX_INCLUDE_TESTS=ON
+  )
----------------
Could we check if these two settings are needed? i.e. are they on by default already in the current cmake config?


================
Comment at: libcxx/utils/ci/aix-install-libcxx.sh:107
+  )
+  env OBJECT_MODE="${bitmode}" cmake --build "${build_dir}/${bitmode}" --target install-cxx install-cxxabi install-unwind
+done
----------------
If a build did not complete successfully, for the ease of find out where it fails, do we want to have an early exit whenever there is an error on setting up cmake and during building?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101959/new/

https://reviews.llvm.org/D101959