[libcxx-commits] [PATCH] D101674: [libc++] [LIBCXX-DEBUG-FIXME] Constexpr char_traits::copy mustn't compare unrelated pointers.
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed May 5 16:34:52 PDT 2021
Quuxplusone planned changes to this revision.
Quuxplusone added a comment.
> We should be able to compare pointers with std::less to solve this problem. [...]
> (will require having some sort of special contract with the compiler that std::less can do that -- this could be done with some sort of builtin)
I agree that that's what WG21 seems to want vendors to do. But that requires coordinating a new pointer-comparison builtin with both Clang and GCC, which is (definitely a good idea but) far above my pay grade. I'm happy to abandon this PR and let someone-not-me pursue the builtin angle...
Discussed offline with @ldionne and decided to sit on this for now, with the intent that someone will pursue adding a builtin at least to Clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101674/new/
https://reviews.llvm.org/D101674
More information about the libcxx-commits
mailing list