[libcxx-commits] [PATCH] D101899: std::forward_list::swap to use propagate_on_container_swap for noexcept specification

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 5 14:49:49 PDT 2021


Quuxplusone added subscribers: ldionne, Quuxplusone.
Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

This does actually look like a pretty straightforward typo in `forward_list`; the other containers all seem to get it right.
It's too bad that none of our tests notice the change; but, the POCCA/POCMA/POCS traits are obscure, and this affects literally nothing but `-std=c++11` mode. I don't think it makes sense to hold up this patch for lack of tests.
(@airglow923 please wait for an approval from "libc++" before landing. @ldionne ping! am I missing anything subtle here?)


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101899/new/

https://reviews.llvm.org/D101899



More information about the libcxx-commits mailing list