[libcxx-commits] [PATCH] D98750: Apply [[standalone_debug]] to some types in the STL.

[Reid Kleckner via Phabricator via libcxx-commits]

rnk added a comment.

Yes. I think Amy has demonstrated that we need this attribute, at least for some complex cases. If libc++ is going to use the attribute in at least one place, I don't think there is much cost to adding it in the other places that we think we could address with unions. The attribute can always be removed later if the alleged UB is resolved.

Our motivation is to reduce object file size by 50%, not to address the UB, and this has been the blocking issue for us since October. @EricWF already indicated that he prefers the attribute. @ldionne, you indicated that you'd prefer to avoid the attribute, but if it is unavoidable in some cases, do you have any other objections, or is this OK?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98750/new/

https://reviews.llvm.org/D98750