[libcxx-commits] [PATCH] D77657: [WIP][libc++] Add an executor that bundles tests for deferred execution

Dan Albert via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 4 15:42:52 PDT 2021


danalbert added a comment.

Re problems 1 and 2 (xfail handling), my idea what that we'd add `--xfail` to the bundler interface and delegate to the test runner to handle that. For Android I need to fit these tests into tradefed <https://source.android.com/devices/tech/test_infra/tradefed>, so our bundler would work by creating the test config files for tradefed and would let it handle xfails. We don't have much reason to interact with LIT again after the tests are built. This more or less matches how we've been running libc++ tests for years, though with some improvements (xfail info is currently manually tracked rather than being given by LIT). I've been carrying a local patch that adds a `--build-only` flag which just ignores xfail annotations and defers all the execution and interpretation to our test runner.

@ldionne do you have an example for 3? Shell tests were hardly a thing the last time I spent any real time here so I'm not sure why multiple run lines would be used in a test.

One other thought is that it would be beneficial for us if we could build //one// bundle rather than a bundle per test, but that's probably impractical.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77657/new/

https://reviews.llvm.org/D77657



More information about the libcxx-commits mailing list