[libcxx-commits] [PATCH] D101638: [libc++] std::to_address mustn't depend on P::element_type.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 4 13:11:26 PDT 2021


ldionne commandeered this revision.
ldionne edited reviewers, added: Quuxplusone; removed: ldionne.
ldionne added a comment.

Commandeering since this has become pretty complicated. We have two issues:

1. `std::to_address` is broken and uses `T::element_type` when it shouldn't.
2. `std::vector<T>::iterator` is not a `contiguous_iterator` because it doesn't support `std::to_address`.

This patch fixes (1), and not (2).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101638/new/

https://reviews.llvm.org/D101638



More information about the libcxx-commits mailing list