[libcxx-commits] [PATCH] D101676: [libc++] [LIBCXX-DEBUG-FIXME] Iterating a string::iterator "off the end" is UB.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Explanation of the change for others who might not have understood it (Arthur explained it to me offline cause I didn't get it):

> `In3` is an iterator equal to `In2.begin()`. We're using overload (5) from https://en.cppreference.com/w/cpp/filesystem/path/path , which expects "a pointer or an input iterator to a null-terminated character/wide character sequence". `In2.data()` fits that description, because it's a raw `char*`; but `In2.begin()` doesn't, because it's an iterator to a character sequence that is not null-terminated. Getting to the null terminator requires iterating "off the end" of the valid range and dereferencing `In2.begin() + In2.size()`, which is `In2.end()`, which is not dereferenceable.
>
> So, with debug iterators, that "off the end" iteration fails a `_LIBCPP_ASSERT`; but even without debug iterators, technically, it's library UB for the test case to be trying to do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101676/new/

https://reviews.llvm.org/D101676