[libcxx-commits] [PATCH] D101770: [libc++] Fix bug with construction of std::tuple involving std::any

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/copy.with_any.compile.pass.cpp:11-14
+// This test makes sure that we can copy/move a std::tuple containing a type
+// that checks for copy constructibility itself, like std::any.
+//
+// Problem showcased in https://reviews.llvm.org/D96523#2730953.
----------------
I'd like to see this test additionally test with `std::any` itself — since this is kind of a subtle interaction between the metaprogramming in both libc++ `tuple` and libc++ `any`, right? Could go in this same file, just under `TEST_STD_VER >= 17`; or could go into `copy.with_std_any.compile.pass.cpp` or something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101770/new/

https://reviews.llvm.org/D101770