[libcxx-commits] [PATCH] D101476: [libcxx][ranges] Add ranges::data CPO.

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: libcxx/include/__ranges/data.h:56
+  template <class _Tp>
+  concept __unqualified_begin =
+    __not_incomplete_array<_Tp> &&
----------------
cjdb wrote:
> I think this is missing `!__member_data<_Tp>`. This suggests a test where `r.data()` and `ranges::begin(r)` are both valid needs to be added.
> 
> I'm also unsure as to why it's called `__unqualified_begin`?
Good catch. I'll name it `__ranges_begin` or something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101476/new/

https://reviews.llvm.org/D101476