[libcxx-commits] [PATCH] D101316: [libcxx][ranges] Add `random_access_{iterator, range}`.

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb accepted this revision.
cjdb added a comment.

Approved, pending comments.



================
Comment at: libcxx/test/libcxx/iterators/iterator.concepts/iterator.concept.random.access/subsumption.compile.pas.cpp:21
+template<std::bidirectional_iterator I>
+requires std::derived_from<std::_ITER_CONCEPT<I>, std::random_access_iterator_tag>
+[[nodiscard]] constexpr bool check_subsumption() {
----------------
Per offline discussion, please remove, and move to `test/std/...`.


================
Comment at: libcxx/test/std/ranges/range.refinements/random_access_range.compile.pass.cpp:36
+
+static_assert(!check_range<cpp20_input_iterator>());
+static_assert(!check_range<forward_iterator>());
----------------
Please also add `cpp17_input_iterator` wherever you check `cpp20_input_iterator`, for completeness' sake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101316/new/

https://reviews.llvm.org/D101316