[libcxx-commits] [PATCH] D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings

[Xing Xue via Phabricator via libcxx-commits]

xingxue added inline comments.


================
Comment at: libcxxabi/src/cxa_personality.cpp:922
         set_registers(unwind_exception, context, results);
+        // Cache base for calculating the address of ttype in
+        // __cxa_call_unexpected.
----------------
sfertile wrote:
> My idea behind splitting out an NFC patch was to have just the interface changes needed to support a datarel base implementation, without any of the functional changes for the datarel implementation. This part of the diff looks like it falls under the later. I'm guessing the intent it to show that this part of the patch is NFC for all existing targets? 
> 
> IMO I think we would be best with 1 interface only patch, and 1 implementation. only patch but others might disagree with me.
> 
> Can you remove this, the write to `exception_header->catchTemp` in the bloc on lines 955-960, and then the read of `exception_header->catchTemp` on line 1150 to make the patch an interface change only?
Done. Also removed the code that gets base from cache.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101545/new/

https://reviews.llvm.org/D101545