[libcxx-commits] [PATCH] D101752: Speedup to_string for integers using zero-copy.

Noel Grandin via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 3 05:08:41 PDT 2021


grandinj added inline comments.


================
Comment at: libcxx/src/string.cpp:442
 //  so we need +1 here.
     constexpr size_t bufsize = numeric_limits<V>::digits10 + 2;  // +1 for minus, +1 for digits10
     char buf[bufsize];
----------------
just a drive-by commentator - why is the wstring version so different from the string version? Surely they should be practically the same?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101752/new/

https://reviews.llvm.org/D101752



More information about the libcxx-commits mailing list