[libcxx-commits] [PATCH] D101737: [libcxx] Implement view.interface.

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver planned changes to this revision.
zoecarver added a comment.

I wanted to get this review up before Monday so that other folks can start on their views work. I'm planning a few changes (mainly to add some tests) so this isn't quite ready for review yet.



================
Comment at: libcxx/include/__ranges/view_interface.h:37
+template <class _Tp>
+concept view =
+  range<_Tp> &&
----------------
I will remove this once the patch lands and I rebase. 


================
Comment at: libcxx/include/__ranges/view_interface.h:130
+  {
+    _LIBCPP_ASSERT(!empty(), "");
+    return *ranges::begin(__derived());
----------------
Add a message here.


================
Comment at: libcxx/include/__ranges/view_interface.h:149
+    _LIBCPP_ASSERT(!empty(), "");
+    return *(--ranges::end(__derived()));
+  }
----------------
Review note: this is used until `ranges::prev` is implemented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101737/new/

https://reviews.llvm.org/D101737