[libcxx-commits] [PATCH] D101731: [libcxx] [test] Fix fs.op.last_write_time for Windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun May 2 14:22:26 PDT 2021


mstorsjo created this revision.
mstorsjo added a reviewer: curdeius.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Don't use stat and lstat on Windows; lstat is missing, stat only provides
the modification times with second granularity (and does the wrong thing
regarding symlinks). Instead do a minimal reimplementation using the
native windows APIs.

This is an alternative to D98641 <https://reviews.llvm.org/D98641>. This one contains more compat churn
at the top of the file (reimplememtations of stat and lstat), but
requires much less modifications to the rest of the test. Therefore
I'd kind of prefer this one out of the two.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101731

Files:
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp
  libcxx/test/support/filesystem_test_helper.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101731.342277.patch
Type: text/x-patch
Size: 4647 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210502/7a9eee34/attachment-0001.bin>


More information about the libcxx-commits mailing list