[libcxx-commits] [PATCH] D80891: [libcxx] adds consistent comparison for `basic_string_view`

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb updated this revision to Diff 342210.
cjdb marked 6 inline comments as done.
cjdb retitled this revision from "[libcxx] adds operator<=> for basic_string_view" to "[libcxx] adds consistent comparison for `basic_string_view`".
cjdb edited the summary of this revision.
cjdb added a comment.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

- adds tests for `wstring_view`, `u8string_view`, `u16string_view`, `u32string_view`
- adds tests for char_traits without `comparison_category` member alias
- adds `TEST_SAME_AS` checks for `<=>` return types
- adds dependency on D101708 <https://reviews.llvm.org/D101708>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80891/new/

https://reviews.llvm.org/D80891

Files:
  libcxx/include/__string
  libcxx/include/string_view
  libcxx/test/std/strings/string.view/string.view.comparison/opcmp.string_view.pointer.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opcmp.string_view.string_view.pass.cpp
  libcxx/test/support/compare_char_traits.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80891.342210.patch
Type: text/x-patch
Size: 18952 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210502/8c8d2019/attachment-0001.bin>