[libcxx-commits] [PATCH] D101676: [libc++] [LIBCXX-DEBUG-FIXME] Iterating a string::iterator "off the end" is UB.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 1 10:06:20 PDT 2021


Quuxplusone updated this revision to Diff 342162.
Quuxplusone added a comment.

poke buildkite


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101676/new/

https://reviews.llvm.org/D101676

Files:
  libcxx/test/std/input.output/filesystems/class.path/path.nonmember/path.factory.pass.cpp


Index: libcxx/test/std/input.output/filesystems/class.path/path.nonmember/path.factory.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/class.path/path.nonmember/path.factory.pass.cpp
+++ libcxx/test/std/input.output/filesystems/class.path/path.nonmember/path.factory.pass.cpp
@@ -6,8 +6,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-// XFAIL: LIBCXX-DEBUG-FIXME
-
 // UNSUPPORTED: c++03
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
@@ -44,7 +42,7 @@
     assert(p == In1);
   }
   {
-    path p = fs::u8path(In3);
+    path p = fs::u8path(In2.data());
     assert(p == In1);
   }
   {
@@ -67,7 +65,7 @@
     assert(p == In1);
   }
   {
-    path p = fs::u8path(u8In3);
+    path p = fs::u8path(u8In2.data());
     assert(p == In1);
   }
   {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101676.342162.patch
Type: text/x-patch
Size: 890 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210501/56e26ed1/attachment.bin>


More information about the libcxx-commits mailing list