[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 30 12:39:58 PDT 2021

ldionne accepted this revision.
ldionne added a comment.

LGTM with nitpick (and assuming CI comes back green).

I still think we should watch out for any unintended consequence of this change. Basically, anyone including `libcxx/include` instead of the properly installed headers will now run into issues after this change (since `__config_site` will not have been included and thus won't be found). That's why this change has so much possibility for breakage. However, once that's fixed, we'll be in a much better place knowing that all users are using the correctly installed (and hence configured) libc++ headers.

Comment at: libcxx/docs/TestingLibcxx.rst:42
+fake installation root of libc++. This installation root has to be updated when
+changes are made to the headers, so you should re-run the `check-cxx-deps` target
+before running the tests manually with `lit` when you make any sort of change,
This target name has been renamed since the original patch. It's now `cxx-test-depends`.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list