[libcxx-commits] [PATCH] D99641: [libcxx] [test] Fix invocable tests on Windows
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 31 23:40:11 PDT 2021
curdeius requested changes to this revision.
curdeius added a comment.
Just to be clear. I agree with Arthur that concept test suite is not the place for testing compiler compatibility quirks.
And, the approach he suggested is superior to ifdefing.
Concerning what I wrote about the possible "precise" ifdef condition, it was just a note, and I really don't want to see such quirks in the code.
And, FYI, this particular clang-cl bug is going to be fixed by D99663 <https://reviews.llvm.org/D99663> (if accepted of course).
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits