[libcxx-commits] [PATCH] D99697: [CMake] Remove {LIBCXX, LIBCXXABI, LIBUNWIND}_INSTALL_PREFIX

Wed Mar 31 22:41:22 PDT 2021

phosek added a comment.

In D99697#2662964 <https://reviews.llvm.org/D99697#2662964>, @Ericson2314 wrote:

> Oh there is a stray `LIBCXX_INSTALL_HEADER_PREFIX` in `LIBCXX_INSTALL_HEADER_PREFIX` that should be removed, FYI.

Thanks for catching that!

> Also, If someone does want the extra knobs after all, making a `LIBCXX_INSTALL_HEADER_DIR`/`LIBCXX_INSTALL_INCLUDEDIR` (same idea, two different possible names) matching `LIBCXX_INSTALL_LIBRARY_DIR` would also fit in with `GNUInstallIdirs` more nicely, I think.

I've made that change in D89013 <https://reviews.llvm.org/D89013>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99697/new/

https://reviews.llvm.org/D99697